Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect sensitive information #41

Open
ylavoie opened this issue Jun 26, 2016 · 4 comments
Open

Protect sensitive information #41

ylavoie opened this issue Jun 26, 2016 · 4 comments

Comments

@ylavoie
Copy link

ylavoie commented Jun 26, 2016

The configuration url can display sensible information on error. Protect or filter out.

@camertron
Copy link

Hey @ylavoie, I think you mean sensitive information. The configuration URL is meant to be passed in as an environment variable, and in the raw case is really only meant for docker containers. Txgh reads this config on initialization, so none of the information can be filtered out. Can you expand a bit on your thoughts here?

@ylavoie
Copy link
Author

ylavoie commented Jul 12, 2016

Yes I meaned sensitive information; sorry french word use in an English phrase. I had an error and all the variables were shown on the end user screen because the package is published by default in development mode.

@camertron
Copy link

Ah ok interesting. Were you using the raw:// config scheme? I'm still not sure I understand how the config was leaked to the end user.

@ylavoie
Copy link
Author

ylavoie commented Jul 12, 2016

The Dockerfile is set for development instead of production

@ylavoie ylavoie changed the title Protect senbible information Protect sensitive information Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants