mingw32-gcc -O2 -c -o src/lfs.o -IC:\Program Files\Luarocks3.4.0 src/lfs.c src/lfs.c: In function 'push_link_target': src/lfs.c:1097:9: warning: implicit declaration of function 'memmove_s'; did you mean 'memmove'? [-Wimplicit-function-declaration] 1097 | memmove_s(target, tsize - 3, target + 4, tsize - 3); | ^~~~~~~~~ | memmove

[fujisheng]

mingw32-gcc -O2 -c -o src/lfs.o -IC:\Program Files\Luarocks3.4.0 src/lfs.c
src/lfs.c: In function 'push_link_target':
src/lfs.c:1097:9: warning: implicit declaration of function 'memmove_s'; did you mean 'memmove'? [-Wimplicit-function-declaration]
1097 | memmove_s(target, tsize - 3, target + 4, tsize - 3);
| ^~~~~~~~~
| memmove

[FractalU]

This report is about a warning at line 1097 in which memmove_s is being used. Apparentlly, mingw gcc doesn't recognize that memmove_s is a part of the standard Windows API.

@hishamhm You've already fixed this issue by the commit e4eae33. There, you've replaced memmove_s with the regular memmove, making the warning above go away.

[hishamhm]

@FractalU thanks for the heads up! About time for a new release, I guess?

[FractalU]

thanks for the heads up! About time for a new release, I guess?

I'm not sure about a new release right now. There is still stuff in the pull request. So far since 1.8.0 the changes are more about maintenance such as changing rockspec, fixing git repo URL,, fixing compiler warnings and similar small fixes. So far, I only pointed out that this issue has already been fixed so it can be closed.

[FractalU]

@hishamhm Actually, I changed my mind. Having a release such as 1.8.0-2 or 1.8.1-1 is in my opinion quite beneficial. The release only includes all these small fixes. The functionality stays exactly the same. Almost all the PRs add some functionality.