Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Link and Footnote reference definitions in syntax tree #243

Merged
merged 5 commits into from
Sep 15, 2018

Conversation

MihaZupan
Copy link
Collaborator

@MihaZupan MihaZupan commented Sep 11, 2018

This does not affect HTML rendering at all, it merely exposes more information to the syntax tree:

  • Keep all LinkReferenceDefinitions (doesn't overwrite same-named ones)
  • Sets the correct lines and spans for them
  • Sets the content and source locations for FootnoteLinkReferenceDefinitions

@MihaZupan MihaZupan force-pushed the all-link-definitions branch 3 times, most recently from dbfa82d to 5ba980b Compare September 14, 2018 00:45
@MihaZupan MihaZupan changed the title Expose all LinkReferenceDefinitions with correct locations Fix Link and Footnote reference definitions in syntax tree Sep 15, 2018
@xoofx
Copy link
Owner

xoofx commented Sep 15, 2018

Thanks for this, looks good, do you think it is complete with enough relevant tests?

@MihaZupan
Copy link
Collaborator Author

MihaZupan commented Sep 15, 2018

Yes.
It is further tested in my project, that currently targets the fork instead of NuGet (it relies on these changes).

@xoofx xoofx merged commit 949d5c0 into xoofx:master Sep 15, 2018
@MihaZupan MihaZupan deleted the all-link-definitions branch October 7, 2018 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants