Cleanup StringBuilderCache #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, the CI on master was broken and it should be fixed now. Could you rebase/merge master to your branch please? Thanks! |
|
Can you fix the conflicts? |
|
Cool, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringBuilderCacheused to inherit fromDefaultObjectCache<StringBuilder>, and instances were being passed around.However, nobody was actually using those instances, with one exception:
CodeInlineParser.All other code uses
StringBuilderCache.Local(). As it turns out, there is actually no reason whyCodeInlineParsercould not do the same.This PR changes
StringBuilderCacheto be astatic class, no longer inheriting fromDefaultObjectCache<StringBuilder>. All references to instances are removed.CodeInlineParserwas modified to useStringBuilderCache.Local()as well.It goes without saying that this is a breaking change, as the class and most of the instance references were public.