Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Setext headings in block quotes #471

Closed
wants to merge 1 commit into from
Closed

Conversation

hamvocke
Copy link
Contributor

@hamvocke hamvocke commented Aug 28, 2020

This PR attempts to fix #465 (spoiler alert: I've introduced another problem).

I've added a new test that makes sure that this markdown

> Hello
> ----
> this is some other text

is parsed as a block quote containing a h2. I made the test pass but introduced another regression around lazy continuations of block quotes. This is quite a head-scratcher for me so I'm getting this out with the failing test, maybe we can start discussing intermediate results and another pair of eyes helps fixing the remaining regression (or making sense of my overall approach)

@xoofx
Copy link
Owner

xoofx commented Sep 1, 2020

Thanks for the PR! Sorry for not being able to review it quickly, I will try to come back to you later this week-end, pretty busy during this week.

This is indeed tricky, mostly because we currently don't know when we are in a continuation line or not, which makes this detection not easy to do.

@xoofx
Copy link
Owner

xoofx commented Oct 3, 2020

Sorry, just back on this bug, I will try to have a look at it this week-end.
Discovered that it was no longer possible to debug the tests nicely because of a static constructor performing markdown parses, so I have fixed that.

@xoofx
Copy link
Owner

xoofx commented Oct 5, 2020

This should be fixed by commit 8b64ce4

@xoofx xoofx closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setext headings in blockquotes
2 participants