Cache the MarkdownParser & Processors #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this makes us free of "Constant overhead" in terms of allocations on the |
xoofx
reviewed
Mar 12, 2021
| /// <summary> | ||
| /// Gets the new blocks to push. A <see cref="BlockParser"/> is required to push new blocks that it creates to this property. |
There was a problem hiding this comment.
Why are the order of the properties are all changed in this file? Could this be done in a separate PR?
There was a problem hiding this comment.
Oh yeah I can try to revert this part. I was doing it to triple-check all state was getting reset
There was a problem hiding this comment.
Changed back to original order
MihaZupan
force-pushed
the
cache-parsers
branch
from
82fdf99
to
40a3b5f
Compare
MihaZupan
force-pushed
the
cache-parsers
branch
from
40a3b5f
to
80ed85e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MarkdownParseris made static (had private ctor before)Block/InlineProcessorgot a set of Setup/Rent/Reset/Release methodsBefore:
After:
