Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate keys on mystake page #1364

Closed
faboweb opened this issue Sep 26, 2018 · 6 comments
Closed

Duplicate keys on mystake page #1364

faboweb opened this issue Sep 26, 2018 · 6 comments
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@faboweb
Copy link
Collaborator

faboweb commented Sep 26, 2018

The keys need to be prefixed as a validator may be in both lists:

image

@faboweb faboweb added bug 🐛 issues related to unhandled errors in the code that need to be fixed staking1 labels Sep 26, 2018
@jbibla
Copy link
Collaborator

jbibla commented Sep 26, 2018

i don't think the validator should appear in both lists. i think we should filter out the unstaked validators from the top list.

@faboweb
Copy link
Collaborator Author

faboweb commented Sep 27, 2018

Why? I could have stake with a validator and am unstaking from him at the same time.

@jbibla
Copy link
Collaborator

jbibla commented Sep 27, 2018

do you mean you may stake 500 atoms to validator x and then later unstake 250 from that same validator ... and therefore validator x would have to appear on both lists?

that makes sense - i hadn't considered that scenario.

this means we should really show how many atoms the user has unbonded from validator x - and also the unbonding period.

just a thought... should we display the unbonding tx in the second list instead of the validator Li?

@faboweb
Copy link
Collaborator Author

faboweb commented Sep 28, 2018

just a thought... should we display the unbonding tx in the second list instead of the validator Li?

This sounds like a good idea. :)

@NodeGuy
Copy link
Contributor

NodeGuy commented Oct 3, 2018

It's hard to recreate this bug now that undelegation is unavailable. Blocked by #1294.

@NodeGuy NodeGuy added the blocked ✋ issues blocked by other implementations/issues label Oct 3, 2018
@faboweb faboweb removed the blocked ✋ issues blocked by other implementations/issues label Oct 8, 2018
@faboweb
Copy link
Collaborator Author

faboweb commented Oct 8, 2018

This is unblocked

@NodeGuy NodeGuy removed high priority ❗ low priority has been discussed, will be addressed later labels Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Development

No branches or pull requests

4 participants