Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TmLiTransaction components duplicated in TmUI #1375

Closed
3 tasks
fedekunze opened this issue Sep 28, 2018 · 0 comments · Fixed by #1385
Closed
3 tasks

TmLiTransaction components duplicated in TmUI #1375

fedekunze opened this issue Sep 28, 2018 · 0 comments · Fixed by #1385
Assignees
@fedekunze
Labels
high priority ❗

Comments

@fedekunze
Copy link
Contributor

fedekunze commented Sep 28, 2018 •
edited
Loading

Description:

TmLiStakingTransaction.vue and TmLiTransaction.vue are duplicated in TmUI and voyager.

Ref: #1310 (comment)

Scope:

  • Delete components on Voyager and import them from TmUI
  • Update redelegation tx to show denom instead of shares
  • Update redelegation tx to show the amount redelegated
@fedekunze fedekunze changed the title Transaction logic duplicated in TmUI LiTransaction components duplicated in TmUI Sep 28, 2018
@fedekunze fedekunze changed the title LiTransaction components duplicated in TmUI TmLiTransaction components duplicated in TmUI Sep 28, 2018
This was referenced Sep 28, 2018
Merged
Closed
@fedekunze fedekunze self-assigned this Sep 30, 2018
@fedekunze fedekunze mentioned this issue Oct 1, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedekunze fedekunze

Labels
high priority ❗
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fedekunze/1375 tmlitransaction duplicate luniehq/lunie
1 participant
@fedekunze