Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tx components should display all the decimals #1442

Closed
jbibla opened this issue Oct 9, 2018 · 10 comments
Closed

tx components should display all the decimals #1442

jbibla opened this issue Oct 9, 2018 · 10 comments
Labels
transactions Improvement of the transaction index and displaying ux-improvement issues that would improve the user experience

Comments

@jbibla
Copy link
Collaborator

jbibla commented Oct 9, 2018

use num.full()

blocked by #1432
@jbibla jbibla added the blocked ✋ issues blocked by other implementations/issues label Oct 9, 2018
@fedekunze
Copy link
Contributor

I don't think this is completely blocked if you use yarn link

@faboweb
Copy link
Collaborator

faboweb commented Mar 4, 2019

All the components? What about the balance header?

@faboweb faboweb removed the blocked ✋ issues blocked by other implementations/issues label Mar 4, 2019
@jbibla
Copy link
Collaborator Author

jbibla commented Mar 5, 2019 •
edited
Loading

this was about transaction components.

@faboweb
Copy link
Collaborator

faboweb commented Mar 5, 2019

this was about transaction components.

my bad

@fedekunze
Copy link
Contributor

screen shot 2019-03-05 at 10 31 43 am

no scientific notation plz

@fedekunze fedekunze added ux-improvement issues that would improve the user experience transactions Improvement of the transaction index and displaying labels Mar 5, 2019
@jbibla
Copy link
Collaborator Author

jbibla commented Mar 5, 2019

lol yes, for sure. why is that happening?

@fedekunze
Copy link
Contributor

🤷‍♂️

@faboweb
Copy link
Collaborator

faboweb commented Mar 6, 2019

This looks like a JS issue "adding a number and a string".
There shouldn't be values in Cosmos that are that small.

@fedekunze
Copy link
Contributor

It’s actually BN, we have to parse it to string before displaying it

@fedekunze
Copy link
Contributor

fixed on develop

@D-Nice D-Nice mentioned this issue Oct 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
transactions Improvement of the transaction index and displaying ux-improvement issues that would improve the user experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@faboweb @jbibla @fedekunze