Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "minimize and persist" feature for action modals #1631

Closed
jbibla opened this issue Nov 22, 2018 · 11 comments
Closed

add "minimize and persist" feature for action modals #1631

jbibla opened this issue Nov 22, 2018 · 11 comments
Labels
action-modal design-work-needed 🎨 issues that require design work before development low priority has been discussed, will be addressed later stale ux-improvement issues that would improve the user experience

Comments

@jbibla
Copy link
Collaborator

jbibla commented Nov 22, 2018

would be great to add the option to minimize the action modals while keeping the data in place - allowing users to navigate around the app with actions in a "draft" state.

screen shot 2018-11-22 at 12 05 52 pm

screen shot 2018-11-22 at 12 05 58 pm

@jbibla jbibla added low priority has been discussed, will be addressed later ux-improvement issues that would improve the user experience labels Nov 22, 2018
@fedekunze
Copy link
Contributor

this is soo cool

@faboweb
Copy link
Collaborator

faboweb commented Dec 11, 2018

The feedback regarding the modal is more negative. We should think about a redesign and test it with colleagues and users.

@fedekunze
Copy link
Contributor

fedekunze commented Dec 11, 2018

@okwme said that with this it'll make modals more understandable

@jbibla jbibla added the design-work-needed 🎨 issues that require design work before development label Dec 12, 2018
@jbibla
Copy link
Collaborator Author

jbibla commented Dec 12, 2018

The feedback regarding the modal is more negative.

i still think this is a strong interaction model - but i think we need to improve the design to address the negative feedback.

@faboweb
Copy link
Collaborator

faboweb commented Dec 13, 2018

But let's not fall in love too much with our children. ;)

@jbibla
Copy link
Collaborator Author

jbibla commented Dec 13, 2018

i appreciate what you're saying fabo - but i don't think we've sufficiently tested this. a couple have seemed confused about why it's "not centred" ... has anyone provided feedback about the interaction or the flow? this would be valuable to know.

@faboweb
Copy link
Collaborator

faboweb commented Dec 13, 2018

I know you have read the same feedback as me. We can continue to improve and test this. Just saying, that if people are confused by the concept in its current form, maybe it is not the best interaction model.

@jbibla
Copy link
Collaborator Author

jbibla commented Dec 13, 2018

this is the feedback from billy:

weird alignment on the page, the box that popped up is right and bottom aligned, the "no governance proposals" is still there. maybe it's cause i'm on a big screen or maybe this is a modal but it didn't pop up right...

another bad modal, its bottom aligned and not totally right aligned but def not centred

i have not heard anyone say "how do i make a proposal / delegate".

also, please notice the difference between the design and the implementation (sizing, spacing, font-sizing - also positioning on page in designs vs. actual)...

screen shot 2018-12-13 at 3 56 16 pm

screen shot 2018-12-13 at 3 56 48 pm

@fedekunze
Copy link
Contributor

fedekunze commented Jan 4, 2019

Who’s assigned on this issue? Are we doing this on this week sprint?

@jbibla
Copy link
Collaborator Author

jbibla commented Jan 4, 2019

no we're not - but i'm working on many form improvements right now #1754

@stale
Copy link

stale bot commented Aug 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 23, 2019
@stale stale bot closed this as completed Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action-modal design-work-needed 🎨 issues that require design work before development low priority has been discussed, will be addressed later stale ux-improvement issues that would improve the user experience
Projects
None yet
Development

No branches or pull requests

3 participants