Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code makeup: wallet.balances property #1708

Closed
sabau opened this issue Dec 6, 2018 · 2 comments
Closed

Code makeup: wallet.balances property #1708

sabau opened this issue Dec 6, 2018 · 2 comments
Labels
high priority ❗ refactor stale

Comments

@sabau
Copy link
Contributor

sabau commented Dec 6, 2018

UI Version: 0.X.X

Description:

wallet.balances is currently an array, but the way we are using is seems it should be a dictionary with denom as key (aka Object), most of the time we map or filter through it.
@faboweb faboweb mentioned this issue Jan 16, 2019
Merged
2 tasks
@faboweb faboweb mentioned this issue Jan 28, 2019
Closed
@jbibla
Copy link
Collaborator

jbibla commented Mar 11, 2019

though this may be true, it feels very low impact from a user / launch-prep perspective ...?

@faboweb faboweb mentioned this issue Mar 11, 2019
Closed
@stale
Copy link

stale bot commented Aug 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 23, 2019
@stale stale bot closed this as completed Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high priority ❗ refactor stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sabau @faboweb @jbibla @fedekunze