Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee informations #1721

Closed
sabau opened this issue Dec 7, 2018 · 10 comments
Closed

Fee informations #1721

sabau opened this issue Dec 7, 2018 · 10 comments
Labels
design-work-needed 🎨 issues that require design work before development epic

Comments

@sabau
Copy link
Contributor

sabau commented Dec 7, 2018

UI Version: 0.X.X

Description:
For a user is a bit hard to understand that he's paying Gas for transactions and to retrive this information later. It would be nice to have in the Voting, Depsit and Transaction actions and show it in a confirmation box: The fee of this operation is X

@fedekunze
Copy link
Contributor

I think the user should eventually define the gas and fees (amount + coin denomination) by herself and also provide the option in the settings to define a default gas and fee

@fedekunze
Copy link
Contributor

cc: @alessio what's the cmd/parameter to estimate the gas cost ?

@alessio
Copy link

alessio commented Dec 7, 2018

The flag --dry-run can be used to perform a simulation of a transaction, w/o broadcasting it. You can use this flag to read an estimate of the gas.

If you use --gas=simulate instead, the transaction will be simulated first (to estimate gas), then executed.

@jbibla
Copy link
Collaborator

jbibla commented Dec 10, 2018

absolutely - we need to do a better job of communicating gas and fees!

@fedekunze
Copy link
Contributor

After the discussion in the sdk channel, I think gas is not relevant to our end users. Clients (voyager) could run a simulation previously and check the estimated gas used and set that value on the gas field.

Regarding fees, imo we should eventually define an input field within the txs modals (Deposit, Vote, Delegate, etc) and have a custom value set as default on the preferences/settings page that's pre-filled on the modals

@faboweb
Copy link
Collaborator

faboweb commented Dec 11, 2018

Proposal:
Don't show the concept of gas to the user. The user only cares about fees he needs to pay (which include gas). Voyager shouldn't care about gas either. Stargate should handle fee calculation as it can reuse calculated minimum fees across multiple requests. A client could request stored minimum fees from Stargate similar to the current "simulate" flag.

@faboweb faboweb changed the title Gas informations Fee informations Dec 11, 2018
@faboweb faboweb added design-work-needed 🎨 issues that require design work before development epic labels Dec 11, 2018
@fedekunze
Copy link
Contributor

Scope:

  • Input transaction fees on the tx modals
  • Run the tx simulation and propose a minimum fee to the input

@jbibla
Copy link
Collaborator

jbibla commented Feb 22, 2019

  1. use tx simulation to get gas price
  2. convert gas price into atoms
  3. display this price in atoms to users
  4. if gas price is too low and transaction is dropped, show button for increasing gas price by x% so user can try again (in action modal)
  • don't show "gas" to users - just show atoms as tx fee

@faboweb
Copy link
Collaborator

faboweb commented Feb 24, 2019

4. if gas price is too low and transaction is dropped, show button for increasing gas price by x% so user can try again (in action modal)

I am not sure we can identify this. Transactions will go to the mempool ready to be claimed by a block proposer and will only after several blocks be dropped.

I propose we do 4. in another iteration

@fedekunze
Copy link
Contributor

moved to #2238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-work-needed 🎨 issues that require design work before development epic
Projects
None yet
Development

No branches or pull requests

5 participants