Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimistic updates for transaction page #1849

Closed
jbibla opened this issue Jan 17, 2019 · 4 comments
Closed

Optimistic updates for transaction page #1849

jbibla opened this issue Jan 17, 2019 · 4 comments
Labels
stale transactions Improvement of the transaction index and displaying ux-improvement issues that would improve the user experience

Comments

@jbibla
Copy link
Collaborator

jbibla commented Jan 17, 2019

from #1118:

instead of blocking the user from proceeding with more submissions / transactions ...

- clear form for new tx's
- show loading icon in sidebar next to transactions link
- include the loading tx in tx history instantly with loading icon and adjust language accordingly
- if it fails, replace loading icons with error icons and replace loading language with error language
- on failure, show button to retry transaction

designs for this more optimistic approach can be seen here: https://zpl.io/bLDW6gQ

Originally posted by @jbibla in #1092 (comment)

@jbibla
Copy link
Collaborator Author

jbibla commented Jan 17, 2019

Originally posted by @sabau in #1284 (comment)

we can do in simpler way:

  • not everything needs to have this unfconfirmed state
  • isolated states

Alternative approach:

  • Just update the state as if succeeded
  • then query for the next block

@jbibla
Copy link
Collaborator Author

jbibla commented Jan 17, 2019

i'd like to include another improvement here:

  • after submitting a tx, if we display the success notification, let's include a link to the transaction on the transaction page (equivalent to the "view message" link displayed below)

  • let's move the notification to the bottom left - this will fit better with the action modals

  • the undo button would be a nice thing to have one day but is not as important as the two previous points and the work @sabau has mentioned above.

  • reminder: errors shouldn't be displayed in notifications anymore. just success messages.

  • successful submissions don't need to be so green 💚

screen shot 2019-01-17 at 10 25 41 am

@jbibla jbibla added ux-improvement issues that would improve the user experience transactions Improvement of the transaction index and displaying labels Jan 25, 2019
@fedekunze
Copy link
Contributor

related #2295

@faboweb faboweb changed the title After form submission - UX (AFSUX) Optimistic updates for transaction page Apr 29, 2019
@stale
Copy link

stale bot commented Aug 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 23, 2019
@stale stale bot closed this as completed Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale transactions Improvement of the transaction index and displaying ux-improvement issues that would improve the user experience
Projects
None yet
Development

No branches or pull requests

2 participants