Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionModal on smaller screens #1897

Closed
faboweb opened this issue Jan 29, 2019 · 1 comment
Closed

ActionModal on smaller screens #1897

faboweb opened this issue Jan 29, 2019 · 1 comment
Assignees
@jbibla
Labels
design-work-needed 🎨 issues that require design work before development low priority has been discussed, will be addressed later ux-improvement issues that would improve the user experience

Comments

@faboweb
Copy link
Collaborator

faboweb commented Jan 29, 2019

The ActionModal is pretty big. In the case of the ModalPropose is spanning more than 100% of the screen on my Mac. Can we improve the styling so it always fits? Google Inboxs modal is about half the size.

ModalPropose
image

ModalSend
image
@faboweb faboweb added bug 🐛 issues related to unhandled errors in the code that need to be fixed ux-improvement issues that would improve the user experience design-work-needed 🎨 issues that require design work before development discuss labels Jan 29, 2019
@jbibla
Copy link
Collaborator

jbibla commented Jan 29, 2019

#1735 can help make these smaller.

the result of #1871 may help as well.

@faboweb faboweb removed the discuss label Jan 29, 2019
@jbibla jbibla mentioned this issue Jan 30, 2019
Closed
@faboweb faboweb added the low priority has been discussed, will be addressed later label Feb 12, 2019
@jbibla jbibla self-assigned this Feb 25, 2019
@jbibla jbibla mentioned this issue Feb 28, 2019
Merged
5 tasks
@jbibla jbibla removed the bug 🐛 issues related to unhandled errors in the code that need to be fixed label Mar 4, 2019
@faboweb faboweb mentioned this issue Mar 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbibla jbibla

Labels
design-work-needed 🎨 issues that require design work before development low priority has been discussed, will be addressed later ux-improvement issues that would improve the user experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faboweb @jbibla