Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle outgoing requests #2175

Closed
jbibla opened this issue Mar 5, 2019 · 4 comments
Closed

Throttle outgoing requests #2175

jbibla opened this issue Mar 5, 2019 · 4 comments

Comments

@jbibla
Copy link
Collaborator

jbibla commented Mar 5, 2019

Is your feature request related to a problem? Please describe.

Voyager makes requests on every block (transactions, rewards). Sometimes this can result in too many outgoing requests.

If Voyager is disconnected, we also make requests every second to try to reconnect.

Describe the solution you'd like

We need a strategy for throttling outgoing requests to avoid using unnecessary resources for our users and to avoid spamming the Stargate APIs.

Additional context

@fedekunze
Copy link
Contributor

I think we could start by querying the txs optimistically with a 6s timeout after we send a tx

@fedekunze
Copy link
Contributor

instead of querying every block

@fedekunze
Copy link
Contributor

ok we can subscribe to new txs events via Tendermint. I don't know yet if we can provide any other type of tag or address tho

@jbibla
Copy link
Collaborator Author

jbibla commented Mar 12, 2019

i'm not sure i understand your proposal @fedekunze. are you suggesting we subscribe to tx events in tendermint and query the REST API if there are new transactions?

@fedekunze fedekunze mentioned this issue Mar 15, 2019
5 tasks
@faboweb faboweb closed this as completed Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants