Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display multisend transactions #2335

Closed
fedekunze opened this issue Mar 23, 2019 · 6 comments
Closed

Display multisend transactions #2335

fedekunze opened this issue Mar 23, 2019 · 6 comments
Labels

Comments

@fedekunze
Copy link
Contributor

fedekunze commented Mar 23, 2019

Is your feature request related to a problem? Please describe.

Support multi send transactions. This have the old send UTXO-like format (inputs and outputs.

This is different from #2149, as those have multiple messages in one transactions, while this is another type of message.

Describe the solution you'd like

Be able to display multisend msg transactions, which consists in a transaction from a sender to multiple recipients.

Describe alternatives you've considered

Add transaction into LiBankTransaction. This can be done by unwrapping this transaction into multiple send transactions

Additional context

{
  "height": "10199",
  "txhash": "2CEAB0A012C9285804FD8DCC8D48A82BD35A176A1861A8705A055DA5B8189FD0",
  "logs": [
    {
      "msg_index": "0",
      "success": true,
      "log": ""
    }
  ],
  "gas_wanted": "200000",
  "gas_used": "35929",
  "tags": [
    {
      "key": "action",
      "value": "multisend"
    },
    {
      "key": "sender",
      "value": "cosmos1dany3yuj5qzcyl33qjcxwc6m478a3wftv347sh"
    },
    {
      "key": "recipient",
      "value": "cosmos1x4p90uuy63fqzsheamn48vq88q3eusykf0a69v"
    },
    {
      "key": "recipient",
      "value": "cosmos13sduv92y3xdhy3rpmhakrc3v7t37e7psqtmrdl"
    }
  ],
  "tx": {
    "type": "auth/StdTx",
    "value": {
      "msg": [
        {
          "type": "cosmos-sdk/MsgMultiSend",
          "value": {
            "inputs": [
              {
                "address": "cosmos1dany3yuj5qzcyl33qjcxwc6m478a3wftv347sh",
                "coins": [
                  {
                    "denom": "uatom",
                    "amount": "10000000"
                  }
                ]
              }
            ],
            "outputs": [
              {
                "address": "cosmos1x4p90uuy63fqzsheamn48vq88q3eusykf0a69v",
                "coins": [
                  {
                    "denom": "uatom",
                    "amount": "9000000"
                  }
                ]
              },
              {
                "address": "cosmos13sduv92y3xdhy3rpmhakrc3v7t37e7psqtmrdl",
                "coins": [
                  {
                    "denom": "uatom",
                    "amount": "1000000"
                  }
                ]
              }
            ]
          }
        }
      ],
      "fee": {
        "amount": null,
        "gas": "200000"
      },
      "signatures": [
        {
          "pub_key": {
            "type": "tendermint/PubKeySecp256k1",
            "value": "AgdcjdT2Pxb2stqtGP0pq8R/KFEhP0Moco561uulsyLj"
          },
          "signature": "7SSmcgTypJZvclilktZaPQdBwP2bvZAnYcolc0yv6ptqC+/SYZzpVdkzgaKPWoOT4jJDynGDtxzGGoYgVgl5AQ=="
        }
      ],
      "memo": ""
    }
  }
}
@fedekunze
Copy link
Contributor Author

@jbibla which approach would you take to display this ?

@faboweb
Copy link
Collaborator

faboweb commented Jun 20, 2019

@jbibla I think we should tackle this at some point. The transaction list floods with withdraw txs for me.

@jbibla
Copy link
Collaborator

jbibla commented Jun 20, 2019

transaction list floods with withdraw txs for me

LOL nice problem to have!


i have some ideas for improving the tx list. i think multisend is a specific tx type - not sure if it refers to withdrawals from more than 1 validator at a time - does it?

@fedekunze
Copy link
Contributor Author

fedekunze commented Jun 20, 2019

one is multisend and the other is a transaction with multiple msgs. They are ≠

@faboweb
Copy link
Collaborator

faboweb commented Jun 20, 2019

True!

@stale
Copy link

stale bot commented Aug 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 23, 2019
@stale stale bot closed this as completed Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants