-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "max" button to amount fields #2670
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
simple UI feature. would be nice to have! |
Set Max button is working on branch mario/2670-add-max-amount. Currently set the entire available balance, so want to discuss about best way to subtract the fee from the available balance. If we click on the button, in the step 2 the fee is 0.000000 ATOM, is this a validation error? It would be cool to include a fee slider to let user set the fee they want. We can include it in step 1 to let us calculate max = (available balance - fee). |
awesome! if you make a draft PR we can see the link to the build and test out the feature 😉
no this is actually correct. if the user has no ATOMs left to pay fees we let them submit a tx without fees. can you add a warning to this section that explains this? i will help with the language.
good thought here. a fee slider could work. i don't know what the best approach is. we could...
alternatively...
@faboweb what do you think? this is related to #2530 |
We decided against a fee selector in favor of less mental overhead for the user. |
so what you're proposing is:
are you opposed to the following proposal?
|
Why do you want to make it more complex? Do we want to force the user to pay for fees? |
my intention is to make it as simple as possible while also letting the user know what's happening. i am in favour of the simplest solution - which i guess at this point is having a max button that doesn't know anything about fees and a message (#2530) that says "hey, you should probably leave some left over for fees". that would be simplest and easiest IMO. |
Is your feature request related to a problem? Please describe.
Often, users want to do make a tx with all the atoms. since there are 6 decimal places, this can be tedious to type out.
Describe the solution you'd like
It is common in these situations to include a
max
button, which will automagically add the total amount left to the amount field for the user.Additional context
Something to consider is the relationship with #2674.
The text was updated successfully, but these errors were encountered: