fix(viewer): delete unused lineHeadMode prop and type

lunit-io · Apr 20, 2023 · 31daebd · 31daebd
1 parent 5d7e07c
commit 31daebd
Show file tree

Hide file tree

Showing 12 changed files with 5 additions and 31 deletions.
diff --git a/libs/insight-viewer/src/Annotation/types.ts b/libs/insight-viewer/src/Annotation/types.ts
@@ -21,9 +21,6 @@ export type ViewerStyle = {
   [styleType in ViewerStyleType]?: CSSProperties
 }
 
-/** @deprecated use arrow line instead */
-export type LineHeadMode = 'normal' | 'arrow'
-
 export type AnnotationMode = 'line' | 'freeLine' | 'polygon' | 'text' | 'arrowLine' | 'ruler' | 'area'
 
 export interface AnnotationBase {

diff --git a/libs/insight-viewer/src/Viewer/AnnotationDrawer/AnnotationDrawer.types.ts b/libs/insight-viewer/src/Viewer/AnnotationDrawer/AnnotationDrawer.types.ts
@@ -1,5 +1,5 @@
 import { SVGProps } from 'react'
-import { Annotation, AnnotationMode, LineHeadMode } from '../../types'
+import { Annotation, AnnotationMode } from '../../types'
 
 export interface AnnotationDrawerProps extends SVGProps<SVGSVGElement> {
   selectedAnnotation: Annotation | null
@@ -19,6 +19,4 @@ export interface AnnotationDrawerProps extends SVGProps<SVGSVGElement> {
   onSelectAnnotation: (annotation: Annotation | null) => void
 
   mode?: AnnotationMode
-  /** @deprecated use arrow line instead */
-  lineHead?: LineHeadMode
 }
diff --git a/libs/insight-viewer/src/Viewer/AnnotationDrawer/index.tsx b/libs/insight-viewer/src/Viewer/AnnotationDrawer/index.tsx
@@ -22,7 +22,6 @@ export function AnnotationDrawer({
   hoveredAnnotation,
   onSelectAnnotation,
   className,
-  lineHead = 'normal',
   mode = 'polygon',
   onAdd,
 }: AnnotationDrawerProps): JSX.Element {
@@ -39,7 +38,6 @@ export function AnnotationDrawer({
     isDrawing,
     isEditing,
     mode,
-    lineHead,
     annotations,
     selectedAnnotation,
     onSelectAnnotation,
@@ -90,7 +88,6 @@ export function AnnotationDrawer({
               isSelectedMode={isSelectedAnnotation}
               showAnnotationLabel={showAnnotationLabel}
               isPolygonSelected={selectedAnnotation?.type === 'polygon'}
-              lineHead={lineHead}
               selectedAnnotationLabel={selectedAnnotation ? selectedAnnotation.label ?? selectedAnnotation.id : null}
               setAnnotationEditMode={setAnnotationEditMode}
               cursorStatus={cursorStatus}

diff --git a/libs/insight-viewer/src/Viewer/AnnotationOverlay/AnnotationOverlay.types.ts b/libs/insight-viewer/src/Viewer/AnnotationOverlay/AnnotationOverlay.types.ts
@@ -1,16 +1,10 @@
-import { Annotation, AnnotationMode, LineHeadMode } from '../../types'
+import { Annotation, AnnotationMode } from '../../types'
 import { AnnotationViewerProps } from '../AnnotationViewer/AnnotationViewer.types'
 
 export interface AnnotationOverlayProps extends AnnotationViewerProps {
   isDrawing?: boolean
   mode?: AnnotationMode
   selectedAnnotation: Annotation | null
-  /**
-   *  normal has no head
-   *  For arrow, an arrow head is added.
-   * @deprecated use arrow line instead
-   */
-  lineHead?: LineHeadMode
   onFocus?: (annotation: Annotation | null) => void
   onAdd?: (annotation: Annotation) => void
   onRemove?: (annotation: Annotation) => void

diff --git a/libs/insight-viewer/src/Viewer/AnnotationOverlay/index.tsx b/libs/insight-viewer/src/Viewer/AnnotationOverlay/index.tsx
@@ -15,7 +15,6 @@ export function AnnotationOverlay({
   showOutline,
   showAnnotationLabel,
   mode,
-  lineHead,
   isDrawing = false,
   isEditing,
   annotationAttrs,
@@ -57,7 +56,6 @@ export function AnnotationOverlay({
           isDrawing={isDrawing}
           isEditing={isEditing}
           mode={mode}
-          lineHead={lineHead}
           onAdd={onAdd}
           onSelectAnnotation={onSelect}
         />

diff --git a/libs/insight-viewer/src/Viewer/PolylineDrawer/PolylineDrawer.types.ts b/libs/insight-viewer/src/Viewer/PolylineDrawer/PolylineDrawer.types.ts
@@ -1,5 +1,4 @@
 import type {
-  LineHeadMode,
   EditMode,
   PolygonAnnotation,
   FreeLineAnnotation,
@@ -11,8 +10,6 @@ import type {
 export interface PolylineDrawerProps {
   annotation: PolygonAnnotation | FreeLineAnnotation | LineAnnotation | ArrowLineAnnotation
   isSelectedMode: boolean
-  /** @deprecated use arrow line instead */
-  lineHead: LineHeadMode
   showAnnotationLabel: boolean
   selectedAnnotationLabel: string | number | null
   setAnnotationEditMode: (mode: EditMode) => void

diff --git a/libs/insight-viewer/src/Viewer/PolylineDrawer/index.tsx b/libs/insight-viewer/src/Viewer/PolylineDrawer/index.tsx
@@ -15,7 +15,6 @@ const PolylineElement = ({
 
 export function PolylineDrawer({
   annotation,
-  lineHead,
   isSelectedMode,
   selectedAnnotationLabel,
   showAnnotationLabel,
@@ -56,7 +55,7 @@ export function PolylineDrawer({
       {points && points.length > 0 && (
         <>
           <PolylineElement isPolygon={isPolygonSelected} style={svgWrapperStyle.outline} points={polylinePoints} />
-          {(lineHead === 'arrow' || type === 'arrowLine') && (
+          {type === 'arrowLine' && (
             <>
               <PolylineElement
                 className={`annotation-polyline ${cursorClassName} `}

diff --git a/libs/insight-viewer/src/hooks/useAnnotationPointsHandler/index.ts b/libs/insight-viewer/src/hooks/useAnnotationPointsHandler/index.ts
@@ -18,7 +18,6 @@ export default function useAnnotationPointsHandler({
   mode,
   isDrawing,
   isEditing,
-  lineHead,
   svgElement,
   annotations,
   selectedAnnotation,

diff --git a/libs/insight-viewer/src/hooks/useAnnotationPointsHandler/types.ts b/libs/insight-viewer/src/hooks/useAnnotationPointsHandler/types.ts
@@ -1,12 +1,10 @@
-import type { AnnotationMode, Annotation, LineHeadMode, EditMode, CursorStatus } from '../../types'
+import type { AnnotationMode, Annotation, EditMode, CursorStatus } from '../../types'
 import type { EditPoints } from '../../utils/common/getEditPointPosition'
 
 export interface UseAnnotationPointsHandlerParams {
   isDrawing: boolean
   isEditing: boolean
   mode: AnnotationMode
-  /** @deprecated use arrow line instead */
-  lineHead: LineHeadMode
   annotations: Annotation[]
   selectedAnnotation: Annotation | null
   hoveredAnnotation: Annotation | null

diff --git a/libs/insight-viewer/src/hooks/useAnnotationPointsHandler/utils/getInitialAnnotation.ts b/libs/insight-viewer/src/hooks/useAnnotationPointsHandler/utils/getInitialAnnotation.ts
@@ -3,7 +3,7 @@ import polylabel from 'polylabel'
 import { LINE_TEXT_POSITION_SPACING } from '../../../const'
 
 import type { Image } from '../../../Viewer/types'
-import type { Point, LineHeadMode, AnnotationMode, Annotation } from '../../../types'
+import type { Point, AnnotationMode, Annotation } from '../../../types'
 
 import { getCircleRadiusByMeasuringUnit } from '../../../utils/common/getCircleRadius'
 

diff --git a/libs/insight-viewer/src/index.ts b/libs/insight-viewer/src/index.ts
@@ -22,7 +22,6 @@ export type {
   Contours,
   Annotation,
   Point,
-  LineHeadMode,
   AnnotationBase,
   PolygonAnnotation,
   LineAnnotation,

diff --git a/libs/insight-viewer/src/types/index.ts b/libs/insight-viewer/src/types/index.ts
@@ -82,8 +82,6 @@ export type ViewerStyle = {
   [styleType in ViewerStyleType]?: CSSProperties
 }
 
-/** @deprecated use arrow line instead */
-export type LineHeadMode = 'normal' | 'arrow'
 export type AnnotationMode = 'line' | 'freeLine' | 'polygon' | 'circle' | 'text' | 'arrowLine'
 
 export interface AnnotationBase {