Skip to content
This repository has been archived by the owner on May 28, 2024. It is now read-only.

Move ButtonPlayer.backgroundColor in favor of PlayContentAction.backgroundColor #25

Open
llucax opened this issue Feb 18, 2021 · 0 comments
Open

Move ButtonPlayer.backgroundColor in favor of PlayContentAction.backgroundColor #25

llucax opened this issue Feb 18, 2021 · 0 comments
Labels
blocked There is an external factor preventing this issue to advance tech-debt Improves the code (maintainability, etc.) without impacting the user direcly
Milestone
v0.4.0

Comments

@llucax
Copy link
Member

llucax commented Feb 18, 2021

Having this fabricated property doesn't make much sense as this is something related to the content player, not the button. The StyledButton can still propagate its color to the PlayContentAction if no backgroundColor was not specified there though, but it doesn't make any sense to have a color associated with an ImageButton for example.

This depends on lunofono/lunofono_bundle#8.
@llucax llucax added the tech-debt Improves the code (maintainability, etc.) without impacting the user direcly label Feb 18, 2021
@llucax llucax added this to the v0.3.0 milestone Feb 18, 2021
@llucax llucax added the blocked There is an external factor preventing this issue to advance label Feb 18, 2021
@llucax llucax modified the milestones: v0.3.0, v0.4.0 Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocked There is an external factor preventing this issue to advance tech-debt Improves the code (maintainability, etc.) without impacting the user direcly
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
1 participant
@llucax