Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the training parameters of your single branch convnext encoder #4

Open
yuecao0119 opened this issue Mar 8, 2024 · 3 comments
Open

Comments

@yuecao0119
Copy link

Hello, your job is so great.

But I would like to ask, is it convenient to disclose the training parameters of your single branch convnext encoder? I am not very able to understand the following part of the code.

def feature_select(self, image_forward_outs):
        if self.select_layer>100:
            image_features = image_forward_outs[-4:]
        else:
            image_features = image_forward_outs[-1]
        return image_features
@luogen1996
Copy link
Owner

These codes of image_features = image_forward_outs[-4:] are not actually used. We directly select the last layer of ConvNeXT to extract visual features. We will revise our codes soon.

@yuecao0119
Copy link
Author

Thank you for your answer.
How should the single-branch convnext in your paper be trained? Because I tried to use your code to train single-branch convnext, the loss effect in the pretrain stage was not very good.
image

@luogen1996
Copy link
Owner

Your loss looks actually good. Single-branch LLaVA-HR performs worse, see our paper.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants