Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bootloader IRQHandler NUCLEO-G431KB #399

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Fix Bootloader IRQHandler NUCLEO-G431KB #399

merged 1 commit into from
Nov 10, 2022

Conversation

BiliouriV
Copy link
Contributor

@BiliouriV BiliouriV commented Nov 8, 2022 •
edited by JeromeGalan
Loading

Description and dependencies

Fix of g4 bootloader project - we have declared mistaken irq handler

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.

WARNING: Do not edit the checklist below.

Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@BiliouriV BiliouriV requested a review from JeromeGalan November 8, 2022 16:40
@BiliouriV BiliouriV self-assigned this Nov 8, 2022
JeromeGalan
JeromeGalan approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@JeromeGalan JeromeGalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK !

@JeromeGalan JeromeGalan merged commit 18426eb into rc_2.8.0 Nov 10, 2022
@JeromeGalan JeromeGalan deleted the fix/boot_g4_irq branch November 10, 2022 15:26
JeromeGalan pushed a commit that referenced this pull request Nov 10, 2022
Merge pull request #399 from Luos-io/fix/boot_g4_irq
b26f71a 
Fix Bootloader IRQHandler NUCLEO-G431KB
JeromeGalan pushed a commit that referenced this pull request Nov 21, 2022
Merge pull request #399 from Luos-io/fix/boot_g4_irq
797fb7f 
Fix Bootloader IRQHandler NUCLEO-G431KB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeGalan JeromeGalan JeromeGalan approved these changes

Assignees

@BiliouriV BiliouriV

Labels
None yet
Projects
Luos contribution project
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BiliouriV @JeromeGalan