Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove patch large data #409

Merged
merged 1 commit into from
Dec 13, 2022
Merged

[Fix] Remove patch large data #409

merged 1 commit into from
Dec 13, 2022

Conversation

Salem-Tho
Copy link
Member

@Salem-Tho Salem-Tho commented Dec 9, 2022

PR Description section

  • Fix old patch of large data (the old bug is fix by making the robus protocol softer)

Description and dependencies

Please include here a summary of the changes and the related issue. List any dependencies that are required for this change.

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.


WARNING: Do not edit the checklist below.


Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@Salem-Tho Salem-Tho self-assigned this Dec 9, 2022
@Salem-Tho Salem-Tho linked an issue Dec 9, 2022 that may be closed by this pull request
@Salem-Tho Salem-Tho added this to the 2.8.0 milestone Dec 9, 2022
Copy link
Member

@JeromeGalan JeromeGalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@JeromeGalan JeromeGalan merged commit a2c669f into rc_2.8.0 Dec 13, 2022
@JeromeGalan JeromeGalan deleted the fix/patch_ack_rmv branch December 13, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Patch long message ack
2 participants