Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix esp build by locking the build system to a given version (new version are not compatible) #419

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Fix esp build by locking the build system to a given version (new version are not compatible) #419

merged 2 commits into from
Feb 10, 2023

Conversation

nicolas-rabault
Copy link
Member

@nicolas-rabault nicolas-rabault commented Feb 6, 2023 •
edited by JeromeGalan
Loading

PR Description section

Description and dependencies

Fix ESP compilation

Changes

Please choose the relevant options:

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s)

Provide a list of the related issues that will be fixed by this PR.

WARNING: Do not edit the checklist below.

Developer section

  • [Documentation] is up to date with new feature
  • [Tests] are passed OK (non regression, new features & bug fixes)
  • [Code Quality] please check if:
    • Each function has a header (description, inputs, outputs)
    • Code is commented (particularly in hard to understand areas)
    • There are no new warnings that can be corrected
    • Commits policy is respected (constitancy commits, clear commits comments)

QA section

  • [Review] tests for new features have been reviewed
  • [Changelog] is up-to-date with expected tags
    🆕 Feature: [Feature] Description...
    🆕 Added: [Feature] Description...
    🆕 Changed: [Feature] Description...
    🛠️ Fix: [Feature] Description...

@nicolas-rabault nicolas-rabault self-assigned this Feb 6, 2023
@nicolas-rabault nicolas-rabault added this to the 2.9.0 milestone Feb 6, 2023
@nicolas-rabault nicolas-rabault changed the base branch from main to rc_2.9.0 February 6, 2023 13:53
JeromeGalan
JeromeGalan approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@JeromeGalan JeromeGalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems OK I haven't any ESP left to test this code.
@Salem-Tho will test the PR.

@JeromeGalan JeromeGalan merged commit 4da6038 into rc_2.9.0 Feb 10, 2023
@JeromeGalan JeromeGalan deleted the fix/esp_build branch February 10, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Salem-Tho Salem-Tho Salem-Tho approved these changes

@JeromeGalan JeromeGalan JeromeGalan approved these changes

Assignees

@nicolas-rabault nicolas-rabault

Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-rabault @Salem-Tho @JeromeGalan