I've made Coverity scan

[chipitsine]

let me know if you are interested in examining findings

[lurcher]

On 28/08/2024 06:13, Ilya Shipitsin wrote: image.png (view on web) <https://github.com/user-attachments/assets/e25b61bf-d891-4685-ac2d-1eeb8a3a7acb> image.png (view on web) <https://github.com/user-attachments/assets/de448d02-59a0-43ec-9dc1-452524ee0fd6> image.png (view on web) <https://github.com/user-attachments/assets/f9b0702d-4a80-442f-a1a8-3721cb4dcb07> let me know if you are interested in examining findings

Doesn't hurt to know stuff.

[chipitsine]

great. I'd suggest to have a look and decide whether Coverity scan is useful (maybe it is not)

please register at https://scan.coverity.com/projects/chipitsine-unixodbc?tab=overview
and apply there for adding yourself to the project. once I approve it, you'll have an access to view findings

[chipitsine]

permission granted. you should be able to see "view defects" button.
be kind to Coverity, it tries best, but UX sometimes is suprising

[lurcher]

On 28/08/2024 09:07, Ilya Shipitsin wrote: permission granted. you should be able to see "view defects" button. be kind to Coverity, it tries best, but UX sometimes is suprising image.png (view on web) <https://github.com/user-attachments/assets/9257978b-ad74-4888-907e-8f4e2a9752cd>

Thanks, I will try and work through the list as time allows.

[chipitsine]

Story behind that is https://www.zabbix.com/forum/zabbix-troubleshooting-and-problems/470258-zabbix-odbc-issue-with-monitoring-oracle-db

We observe something that looks like an issue either on unixODBC side or zabbix side

I'll be back :)

[chipitsine]

I've noticed some fixes: 9135558

I'll rerun analysis later today. Due to coverrity limits we can run as much as 3 scan daily.

[chipitsine]

@lurcher , what do you think if I'll create a pull request which will set up weekly (or monthly) run of Coverity scan ?
after all it was somewhat useful

[lurcher]

Are there more changes like this left to do?

[chipitsine]

"like this" you mean introducing new workflow ? or addressing coverity findings ?

[lurcher]

No, I mean if you ran it now, would it suggest things to do?

[chipitsine]

there are 129 findings. I'm afraid to touch that code, it is too complicated and fragile (for me) to change it without tests. Maybe, I'll try it after I implement some tests

currently, I'm done with reviewing findings. I would like to setup monthly scan workflow (no need to run often taking into account that changes are infrequent)