You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CLI input of github://SomeUser/SomeRepository is passed to makeUrl (via commands/make.lua)
makeUrl replaces the user and repository name with the above string that hardcodes the master branch
makeUrl assigns the makeHttp handler (due to the https;// prefix of the resulting string)
The handler fetches the unavailable address and fails with a 404 error
Bonus The CLI gets stuck in the event loop instead of exiting (separate issue)
Since people can rename their deployment branch this was never a perfect solution, but now that there are at least the two default branch names to consider it completely breaks down.
Brainstorming ideas for a solution:
Request both default URLs and hope one of them exists? (not great)
Fetch whatever is the latest release, via GitHub API? (might be complicated)
Simply fetch the latest commit (HEAD) instead of a proper release? (seems like a workaround/hack)
Something else?
The text was updated successfully, but these errors were encountered:
GitHub has updated all repositories to use
main
as their default branch name, but lit seems to always want to accessmaster
(and subsequently fails to install the package):I believe this might be the relevant portion of the code:
lit/libs/core.lua
Lines 504 to 505 in 52abe66
I think the problematic flow is as follows:
github://SomeUser/SomeRepository
is passed tomakeUrl
(viacommands/make.lua
)makeUrl
replaces the user and repository name with the above string that hardcodes themaster
branchmakeUrl
assigns themakeHttp
handler (due to thehttps;//
prefix of the resulting string)Since people can rename their deployment branch this was never a perfect solution, but now that there are at least the two default branch names to consider it completely breaks down.
Brainstorming ideas for a solution:
HEAD
) instead of a proper release? (seems like a workaround/hack)The text was updated successfully, but these errors were encountered: