Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update/re-examine Visual Studio versions #586

Closed
squeek502 opened this issue Mar 8, 2022 · 1 comment · Fixed by #587
Closed

CI: Update/re-examine Visual Studio versions #586

squeek502 opened this issue Mar 8, 2022 · 1 comment · Fixed by #587
Labels

Comments

@squeek502
Copy link
Member

squeek502 commented Mar 8, 2022

Our MSVC versions in CI are getting out-of-date, might want to update them and potentially drop some of the older versions. Right now we test 2017 as the 'main' version and then 2015/2019 for a few targets:

https://ci.appveyor.com/project/racker-buildbot/luv/builds/42820581

EDIT: Libuv tests 2017 / 2019 / 2022 in CI, and their README mentions that MSVC 2015 works (but the README is likely outdated as the most recent version it mentions is 2017, so unsure if they plan to support 2015 as a minimum version).

@squeek502 squeek502 added the ci label Mar 8, 2022
@squeek502
Copy link
Member Author

I'm thinking about keeping the current 2015 tests, and then moving the rest to just use 2022. That way we can ensure we maintain a minimum supported MSVC (2015) and ensure that we build using the latest version. We won't ensure that the in-between versions will still build properly, but it seems somewhat unlikely that we would introduce problems specific to an in-between version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant