Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template inserts with duplicate value are empty #14

Closed
luwes opened this issue Jul 22, 2019 · 1 comment · Fixed by krausest/js-framework-benchmark#621
Closed

template inserts with duplicate value are empty #14

luwes opened this issue Jul 22, 2019 · 1 comment · Fixed by krausest/js-framework-benchmark#621
Assignees
@luwes
Labels
bug Something isn't working

Comments

@luwes
Copy link
Owner

luwes commented Jul 22, 2019

Noticed there was an issue with inserts that have the same value.
https://codesandbox.io/s/sinuous-template-issue-t3o57

Probably because of

sinuous/packages/sinuous/h/src/insert.js

Line 9 in a105a1e

if (value === current);

@luwes luwes added the bug Something isn't working label Jul 22, 2019
@luwes luwes self-assigned this Jul 22, 2019
@dyu
Copy link

dyu commented Jul 23, 2019

I was about to file an issue with this problem (discovered this last week). Great job with sinuous btw :-)

@luwes luwes closed this as completed in 2a1e366 Jul 23, 2019
@luwes luwes reopened this Jul 23, 2019
@luwes luwes closed this as completed Jul 23, 2019
@luwes luwes mentioned this issue Jul 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luwes luwes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Sinuous v0.12.6
2 participants
@dyu @luwes