Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested transactions throw error #66

Closed
mrjjwright opened this issue Feb 2, 2020 · 2 comments
Closed

Nested transactions throw error #66

mrjjwright opened this issue Feb 2, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mrjjwright
Copy link
Contributor

mrjjwright commented Feb 2, 2020

A nested transaction (another transaction called during this callback), if you intend to allow them, will throw a Cannot read property 'forEach' of undefined on line 65 because the queue is set to undefined by the nested tx after it runs. Perhaps set a flag and skip all this in nested txs or something?

image

@luwes luwes self-assigned this Feb 2, 2020
@luwes luwes added the bug Something isn't working label Feb 2, 2020
@luwes
Copy link
Owner

luwes commented Feb 2, 2020

ah yes thanks, good find! will look into this soon.

@mrjjwright
Copy link
Contributor Author

thanks!

@luwes luwes closed this as completed in 733cd94 Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants