Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading scrolling estimate for different screen sizes #65

Open
dorisjlee opened this issue Jan 18, 2021 · 0 comments
Open

Misleading scrolling estimate for different screen sizes #65

dorisjlee opened this issue Jan 18, 2021 · 0 comments
Labels
bug Something isn't working easy Easy to fix; Good issues for newcomers

Comments

@dorisjlee
Copy link
Member

The scrolling estimate for the "Scroll more for X charts" is based on a static estimate based on a laptop-sized screen.
On my 23-inch monitor, the full width of the widget actually displays all the recommendations, so the scroll for 2 more was a bit misleading:

df = pd.read_csv("https://raw.githubusercontent.com/lux-org/lux-datasets/master/data/airbnb_nyc.csv")
df = df[
        [
            "id",
            "name",
            "host_id",
            "host_name",
            "neighbourhood_group",
            "neighbourhood",
            "latitude",
            "longitude",
            "room_type",
            "price",
            "minimum_nights",
            "number_of_reviews",
        ]
    ]
df

image

We should modify the scroll estimate code to take into account the actual number of visualizations outside of the viewable region, so that it is adaptive to different widget widths (and screen sizes).

@dorisjlee dorisjlee added bug Something isn't working easy Easy to fix; Good issues for newcomers labels Jan 18, 2021
@dorisjlee dorisjlee added this to the S1: January 2021 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy Easy to fix; Good issues for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant