Upstream says don't directly call concat::setup

[BillWeiss]

On ~modern versions of concat, concat::setup isn't to be called directly, and using it logs this warning:

Warning: Scope(Class[Concat::Setup]): concat::setup is deprecated as a public API of the concat module and should no longer be directly included in the manifest.

Concat 1.0.0 removed the need to include concat::setup, and 1.1.0 added the deprecation warning.

I removed a test that relied on this, couldn't think of where to add some, but I could if you can think of them :)

[luxflux]

Thanks for pointing this out and fixing!

Rather than removing the test, could you replace the should with should_not? 😄

Also, could you update the Modulefile with the correct dependencies?

[luxflux]

Ah, just saw that the Modulefile is ok.

[BillWeiss]

Sure! Adding that test now.

[BillWeiss]

Oh, no, that won't work. concat will implicitly do concat::setup, so the class exists, we just don't include it. Hmm...

I guess we could leave the test in place, since that makes sure the concats are working?

[BillWeiss]

I think we should leave the test out. We're already testing the concats happening, concat::setup is an implementation detail of concat that we don't care about.

[luxflux]

Yeah, no need to test internals of another library. Sorry for misleading the should_not, could have thought about this :/

Thanks for your work!