Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Manual image cropping with filters #196

Closed
rolandschaub opened this issue Jul 31, 2018 · 4 comments · Fixed by #474
Closed

Feature request: Manual image cropping with filters #196

rolandschaub opened this issue Jul 31, 2018 · 4 comments · Fixed by #474
Assignees

Comments

@rolandschaub
Copy link
Member

When applying a filter to an image that results in image cropping, there is currently no way to manually define the cropping area. There could be a button next to the filter dropdown with a cropping icon that opens a cropping dialog. There are a number of JavaScript libraries for this purpose:

https://ourcodeworld.com/articles/read/281/top-7-best-image-cropping-javascript-and-jquery-plugins

The aspect ratio of the cropping zone would have to be fixed according to the filter settings.

@nadar
Copy link
Member

nadar commented Aug 2, 2018

we should avoid using jQuery. It must be: pure angularjs code or native javascript code.

@nadar
Copy link
Member

nadar commented Jan 24, 2020

maybe something like this? https://github.com/CrackerakiUA/ui-cropper

@rolandschaub
Copy link
Member Author

Yes, this looks good.

@nadar
Copy link
Member

nadar commented Mar 18, 2020

  • add "edit" button in file detail
  • create a copy of the file
  • apply changes
  • if "replace" original is select, replace the original file and remove all filter versions

@nadar nadar mentioned this issue Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants