Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectModel valueExisitsInOptions issue #306

Closed
rochdi80tn opened this issue May 28, 2019 · 3 comments
Closed

SelectModel valueExisitsInOptions issue #306

rochdi80tn opened this issue May 28, 2019 · 3 comments
Labels

Comments

@rochdi80tn
Copy link
Contributor

In valueExisitsInOptions functions we should use item[$scope.optionsvalue] and not item.value to compare to the given value
This issue will be visible if we use a different value key other than value

zaa.directive("zaaSelect", function() {

if (value == item.value) {

@nadar
Copy link
Member

nadar commented May 28, 2019

Yes, i agree. Would you like to send a PR?

@rochdi80tn
Copy link
Contributor Author

@nadar Seems that it happens you had just committed a change to directives.js causing a conflict with my pull request

@nadar
Copy link
Member

nadar commented May 28, 2019

its not a problem, i can resolve conflicts while merging - or create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants