Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading use of the note_add icon #668

Closed
hbugdoll opened this issue Oct 1, 2021 · 1 comment · Fixed by #672
Closed

Misleading use of the note_add icon #668

hbugdoll opened this issue Oct 1, 2021 · 1 comment · Fixed by #672

Comments

@hbugdoll
Copy link
Member

hbugdoll commented Oct 1, 2021

Introduction: The note_add icon (page icon with a plus symbol) is used at several places in the LUYA ecosystem to represent an addition to something.
But it should only be used on the Create new page button in the CMS module, in the same way create_new_foldericon is used for the Add folder button.

luya_add_buttons

(Therefor and for replacing the note_add admin menu icon another issue was opened in the CMS module repo: luyadev/luya-module-cms#362)


The following changes are suggested:

1.) User Preferences > section Devices:
note_add --> devices

luya_devices

2.) System > Addition log entry @ dashboard and other default dashboard (e.g. in the news module):
note_add --> add_box

Dashboards

3.) AWS Overview (ApiOverviewController), AWS Group Auth (ActiveWindowGroupAuth), AWS User History (UserHistorySummaryController) and AWS User History Test (UserHistorySummaryActiveWindowTest):
note_add --> add_box


@nadar If you agree to this, I would make a PR.

@nadar
Copy link
Member

nadar commented Oct 1, 2021

sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants