Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spellchecking for file upload button #91

Closed
nick-denry opened this issue Apr 9, 2018 · 8 comments
Closed

Remove spellchecking for file upload button #91

nick-denry opened this issue Apr 9, 2018 · 8 comments
Assignees
Labels
Milestone

Comments

@nick-denry
Copy link
Contributor

Storage upload button has unwanted spell checking in Firefox 59.0.2 if btn text clicked.

2018-04-10 01 12 55

This happens because button has contenteditable attribute set to true. For me it woks with contenteditable attribute set to false via browser debug panel, but if it is really needed, html5 attribute spellcheck="false" should be set.

https://html.spec.whatwg.org/multipage/interaction.html#spelling-and-grammar-checking

@nick-denry nick-denry changed the title Remove spellchecking for image upload button Remove spellchecking for file upload button Apr 9, 2018
@TheMaaarc TheMaaarc self-assigned this Apr 10, 2018
@TheMaaarc TheMaaarc added the bug label Apr 10, 2018
@nadar
Copy link
Member

nadar commented Apr 10, 2018

@nick-denry @TheMaaarc I have never seen such a correction. But if spellcheck="false" works, we should do this maybe.

@nick-denry
Copy link
Contributor Author

nick-denry commented Apr 10, 2018

I guess that problem will occur only at Linux i18n versions of FF, cause spellchecking language there is set to English by default no matter what the real FF UI or pages language is. So, it's maybe a small percentage of users affected, but there is no need for spellchecking anyway.

@nadar
Copy link
Member

nadar commented Apr 10, 2018

would you like to send a PR @nick-denry?

btw: https://caniuse.com/#feat=spellcheck-attribute

@nadar nadar closed this as completed in 4bcfbab Apr 11, 2018
@nadar nadar added this to the 1.1.1 milestone Apr 11, 2018
@nick-denry
Copy link
Contributor Author

@nadar I'm a bit late, sorry. Stackoverflow says that spellcheking on mobile browsers can be disabled too.

Have a look on this https://stackoverflow.com/a/254716 pls. Should we do that?

@nadar
Copy link
Member

nadar commented Apr 11, 2018

mobile browser should respect spellcheck=false.

@nick-denry
Copy link
Contributor Author

nick-denry commented Apr 11, 2018

mobile browser should respect spellcheck=false.

No. Information from your link https://caniuse.com/#feat=spellcheck-attribute

The partial support in mobile browsers results from their OS generally having built-in spell checking instead of using the wavy underline to indicate misspelled words. spellcheck="false" does not seem to have any effect in these browsers.

Below the table.

@nick-denry
Copy link
Contributor Author

nick-denry commented Apr 11, 2018

Why do we need contenteditable="true"?

UPD. We could leave it as is if you want. Or I could do a pr.

@nadar
Copy link
Member

nadar commented Apr 11, 2018

contenteditable is because of the drag and drop possibiltie i assume.

Sure we can also provie autocomplete="off" autocorrect="off" autocapitalize="off" if you like. Please send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants