Sorry for such a silly mistake!

I need an advise on Unit Tests. I am not good enough in them.

Currently, the LangSwitcher Tests rely on data from cms_nav_item table in luya_env_phpunit db. The data refer to only one language (en). So in tests we always have a second link to a German homepage. I need to add some data in cms_nav_item for another language to test the LangSwitcher transitions between some internal pages (with and without query string).

What should I do?

In the next version of the core we have an append function:

https://github.com/luyadev/luya/blob/master/core/helpers/Url.php#L133-L169

Maybe we can use this one afterwards. Also we need a unit test.

in order to test only the lang switcher with sqlite, there is a test for that: https://github.com/luyadev/luya-module-cms/blob/master/tests/src/widgets/LangSwitcherSqliteTest.php

so you can just run: ./vendor/bin/phpunit tests/widgets/LangSwitcherSqliteTest.php to only test that file and don't care about the rest.

@Antikon Is there something i can help? or should we close this PR?

I am going to close this PR because:

• The PR has no activity for a long time.
• The PR does not have Unit Tests.
• The PR is not valid.
• The PR author does not respond to questions are comments.

If the author (you) or someone is picking up the PR again, feel free to reopen. We don't want to wast the time you have spent on the PR. Also if you need help please let us know. Its not our aim to close PR's but we want to keep the repository activity as clean as possible.

If you think this is still important or there are more/new informations. Please reopen the PR and let us know.