Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

narwhalify BaseDatetimeTransformer #375

Open
limlam96 opened this issue Jan 6, 2025 · 0 comments
Open

narwhalify BaseDatetimeTransformer #375

limlam96 opened this issue Jan 6, 2025 · 0 comments

Comments

@limlam96
Copy link
Contributor

limlam96 commented Jan 6, 2025

make BaseDatetimeTransformer polars compatible while maintaining backwards compatibility with pandas.

Why?

Making the project polars compatible for speed benefits. Narwhals allows us to do this piece by piece and maintain compatibility between components as it makes it possible to pass pandas dataframes to polars logic. This involves converting between pandas/polars dataframes.

How?

convert logic in BaseDatetimeTransformer to function with polars dataframes and add narwhalify decorators to methods to ensure compatibility with pandas dataframes.

Update testing where required.

An example narwhalification PR can be found #356

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant