Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converted basenominaltransformer to polars #335

Merged
merged 6 commits into from
Nov 7, 2024
Merged

converted basenominaltransformer to polars #335

merged 6 commits into from
Nov 7, 2024

Conversation

limlam96
Copy link
Contributor

@limlam96 limlam96 commented Oct 17, 2024 •
edited
Loading

edited transformer and tests to use narwhals framework

#334

@limlam96 limlam96 mentioned this pull request Oct 17, 2024
Closed
@limlam96 limlam96 marked this pull request as ready for review October 17, 2024 10:47
davidhopkinson26
davidhopkinson26 requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we also need to edit inverse_transform. It has a replace operation in there.

@limlam96
Copy link
Contributor Author

limlam96 commented Nov 7, 2024

think we also need to edit inverse_transform. It has a replace operation in there.

inverse_transform is in 'NominalToIntegerTransformer' so was leaving for that issue? unless i'm mixed up!

@davidhopkinson26
Copy link
Contributor

think we also need to edit inverse_transform. It has a replace operation in there.

inverse_transform is in 'NominalToIntegerTransformer' so was leaving for that issue? unless i'm mixed up!

My bad sorry!

@davidhopkinson26 davidhopkinson26 merged commit 7ce32de into main Nov 7, 2024
10 checks passed
@davidhopkinson26 davidhopkinson26 deleted the feature/narhwals_basenom branch November 7, 2024 13:50
@davidhopkinson26 davidhopkinson26 mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhopkinson26 davidhopkinson26 davidhopkinson26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@limlam96 @davidhopkinson26