refactored CheckNumericMixin #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO - make new test run in polars/pandas once baseimputer PR completes |
davidhopkinson26
requested changes
Nov 7, 2024
davidhopkinson26
approved these changes
Nov 11, 2024
FBruzzesi
reviewed
Nov 18, 2024
Comment on lines
+180
to
181
| # check weight not inf, not currently a narwhals efficient way to do this | ||
| if np.isinf(X[weights_column].to_numpy()).any(): |
There was a problem hiding this comment.
Hey everyone! I wanted to reach out to mention that we just added Series|Expr.is_finite() method.
It is not fully consistent with nulls across different pandas dtype backends, but you check for null in the block above.
As we just made a release as well, it is available for narhwals>=1.14.
Have a good one 🎉
There was a problem hiding this comment.
Hey, ah amazing! will have a play with this soon + appreciate you letting us know :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored for narwhals
spotted that this wasn't being used consistently across numeric file, so also addressed this
#336