seems to be working

minor cleanup in files
not 100% sure about the MADCTL table, but our display is correctly rotated 90°

Author: Elliot Williams

api_drivers/common_api_drivers/display/nv3007/_nv3007_init.py

@@ -1,4 +1,5 @@
 # Copyright (c) 2024 - 2025 Kevin G. Schlosser
+# NV3007 version (c) 2025 Elliot Williams who just ported init code taken from the internets
 
 import time
 from micropython import const  # NOQA
@@ -43,13 +44,10 @@
 _CMD_PIXSET  = const(0x3A)
 _CMD_GETSCANLINE= const(0x45)
 
-
 def init(self):
     param_buf = bytearray(12)
     param_mv = memoryview(param_buf)
 
-    ## Begin translation
-
     param_buf[0] = 0xa5
     self.set_params(0xFF, param_mv[:1])
 
@@ -264,7 +262,7 @@ def init(self):
     self.set_params(0xc6, param_mv[:1])
 
     param_buf[:2] = bytearray([0x33, 0x33]) #/ CLKCTRL16
-    self.set_paramw(0xC8, param_mv[:2])
+    self.set_params(0xC8, param_mv[:2])
 
     param_buf[0] = 0x68 #/ CLKCTRL17
     self.set_params(0xC9, param_mv[:1])

api_drivers/common_api_drivers/display/nv3007/nv3007.py

@@ -6,7 +6,6 @@
 import lcd_bus  # NOQA
 import display_driver_framework
 
-### begin straight-up copy from GC9A01 driver
 STATE_HIGH = display_driver_framework.STATE_HIGH
 STATE_LOW = display_driver_framework.STATE_LOW
 STATE_PWM = display_driver_framework.STATE_PWM
@@ -23,38 +22,10 @@
 
 class NV3007(display_driver_framework.DisplayDriver):
 
-    ## this is probably wrong!
     _ORIENTATION_TABLE = (
         0,
         _MADCTL_MX | _MADCTL_MV,
         _MADCTL_MY | _MADCTL_MX,
         _MADCTL_MY | _MADCTL_MV
     )
 
-    # virtual uint8_t getMadCtl(uint8_t r) const
-    # {
-    #   static constexpr uint8_t madctl_table[] =
-    #   {
-    #                                      0,
-    #     MAD_MV|MAD_MX|MAD_MH              ,
-    #            MAD_MX|MAD_MH|MAD_MY|MAD_ML,
-    #     MAD_MV|              MAD_MY|MAD_ML,
-    #                          MAD_MY|MAD_ML,
-    #     MAD_MV                            ,
-    #            MAD_MX|MAD_MH              ,
-    #     MAD_MV|MAD_MX|MAD_MY|MAD_MH|MAD_ML,
-    #   };
-    #   return madctl_table[r];
-    # }
-
-
-## end straight-up copy
-
-
-    ## other bits to implement:
-    # uint8_t getColMod(uint8_t bpp) const override { return 0x05; }
-    # uint8_t getMadCtl(uint8_t r) const override { return MAD_MV | MAD_MY; }
-    # _cfg.offset_y  = 12;
-
-    ## src/lgfx/v1/panel/Panel_NV3007.hpp
-    ##  _cfg.offset_y  = 12;