fix for breaking iOS header change in RN 0.40.0

[danieldkim]

For the breaking "iOS native headers moved" change in RN 0.40.0. Fixes #541. Addresses facebook/react-native#11725.

[rt2zz]

🥂

[danieldkim]

Thanks! 🥂

[rt2zz]

@danieldkim is this change backwards compatible with older react-native versions?

[danieldkim]

@rt2zz I haven't tested that yet, tbh. however, the description of this change in the RN release notes suggests not ...

[danieldkim]

i'll do a quick test ... hold, please

[danieldkim]

@rt2zz it's not. generates a compiler error in Xcode with 0.39.2.

[danieldkim]

Relevant discussion at facebook/react-native#11614. It looks like the RN team has decided not to support the old import style leaving it to library developers to deal with branching (if they choose).

[michalmmm]

Thanks a lot!

[rt2zz]

Thanks for looking into that @danieldkim. Looks like v1 is coming up :D

[merapi]

guys, you integrated breaking change into master without changing version... (my project stopped working)

[rt2zz]

@merapi are you installing react-native-camera from github master? this is risky, we are back to shipping semi-regular releases so I would recommend install v0.4

I suspect there are a large number of people in your situation however, so lets do this: I will make a new branch next with this change, and npm publish v1.0.0-alpha1

[danieldkim]

@rt2zz OK, I've been pointing my package.json at master to get the latest and greatest. master should now only get critical bug fixes and I should track the next branch for shiny new stuff?

[danieldkim]

I mean I have no choice since I am on RN 0.40.0, so if that isn't the case my only option to make sure I always get the latest shiny new is to regularly sync to my fork, which would seem kinda backward.

[rt2zz]

@danieldkim ya this is non-ideal but most of the ecosystem is not rn 0.40 ready yet (maps, branch off the top of my head), so I think we are going to see more users point to master on <0.40 than vice-versa. Going to be pain either way.

In the short term I am going to merge all new features against #next branch, so I think if you want to more or less continue how things were I would point you installation to lwansbrough/react-native-camera#next. Hopefully this will be short lived.

[danieldkim]

@rt2zz great, thanks that'll make things easier for me. fyi, maps has pushed their fix for this out.

[ksrawat]

@danieldkim is it possible to draw a rectangle/bound line around barcode area when detected? I know we get bound data, could you please simplify this for me if possible. would appreciate this.