takePicture a file descriptor opened causing "too many files opened" error

[rformato]

It seems like each time takePicture is called, a new file descriptor is created and never closed, bringing to an error in the long run when no more file descriptor can be created.

You can just loop a takePicture call and launch this shell command
lsof | grep node

to see how many opened files you have

Can you confirm it's a file descriptor leak?

[rformato]

I think the line causing not closing file descriptors is
https://github.com/lwille/node-gphoto2/blob/master/src/camera_helpers.cc#L346

Files are closed only if both target_path and socket_path are not empty

[lpinca]

@rformato i think that you are right, if this if (!req->target_path.empty() || !req->socket_path.empty()) { fixes the issue make a pull request, @lwille will probably merge it.

[lwille]

Please confirm the fix by @Sija - it's merged and looks fine, but I can't run any tests here.

[Sija]

I'm testing it for the last few days and I can confirm it's working damn fine! :)
Edit: nvm; @lwille I misread your comment and thought it's directed at me.

[lwille]

I'm sure it does :)
I'll push a new release as soon as I'm back home.

[lwille]

Should be fixed in 0.1.7 (ba9a9b9)