Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcut for open in external browser #1098

Closed
Davidy22 opened this issue Mar 13, 2022 · 6 comments · Fixed by #1103
Closed

Keyboard shortcut for open in external browser #1098

Davidy22 opened this issue Mar 13, 2022 · 6 comments · Fixed by #1103

Comments

@Davidy22
Copy link
Contributor

A keyboard shortcut for opening feeds in a browser would be nice, so I can keep my hands fully on the keyboard when pushing through my feeds. There's some amount of stuff on my feed that only renders right in the browser, so I want to open those in Firefox while I'm churning through the feeds list then afterwards go through the firefox tabs to see the rest of the stuff I wanted to see.

A way to scroll the current viewed article without taking my hands off the keyboard would be nice too, but I feel like this is something that's already in the program and I just haven't found it yet.

@lwindolf
Copy link
Owner

Good idea!

@mozbugbox
Copy link
Contributor

mozbugbox commented Mar 19, 2022

There is an action called 'launch-selected-item-in-external-browser' action. You just need to bind it to a specific key.

@Davidy22
Copy link
Contributor Author

Went in real quick, took a short look around, made a tiny bit of additions but haven't actually tested or compiled yet because random libs that I have installed it thinks aren't installed and I don't have time to get the build working right now. If this is pretty much it that'll be great, otherwise I'll maybe find time in the next month to come back and get the build to work so I can test and finish a pr

@lwindolf
Copy link
Owner

@Davidy22 Looks good. For completeness we should add the hotkey to the help document in doc/html/reference_en.html. Feel free to make a PR!

@Davidy22
Copy link
Contributor Author

Still haven't actually run it but if it worked for you I'll make the PR.

@Davidy22
Copy link
Contributor Author

This is the first time I've made a pull request without building and testing and somehow this was the one PR I make where I get it in on the first try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants