Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placement scriptlet not called when creating an instance using --target flag #1221

Closed
victoitor opened this issue Sep 13, 2024 · 0 comments
Closed
Assignees
Labels
Bug Confirmed to be a bug Easy Good for new contributors
Milestone

Comments

@victoitor
Copy link

victoitor commented Sep 13, 2024

When creating an instance using the --target flag to a specific cluster member and a placement scriptlet is defined through instances.placement.scriptlet, it is not called to check if placement restrictions apply. This can lead to inconsistent configurations similar to #589 and #1207 if the consistency of a configuration is checked through the placement scriptlet and user keys instead of through incus defined keys.

It should be noted that the placement scriptlet is called if --target is used with a cluster group, instead of a cluster member.

Even though the user sets the target, the scriptlet should be called having the target machine as the unique node in candidate_members as defined in the instance placement scriptlet documentation.

This change can better guarantee project rules defined through the placement scriptlet if it is used.

@victoitor victoitor changed the title Placement scriptlet not called when creating and instance using --target flag Placement scriptlet not called when creating an instance using --target flag Sep 13, 2024
@stgraber stgraber added Bug Confirmed to be a bug Easy Good for new contributors labels Sep 23, 2024
@stgraber stgraber added this to the incus-6.6 milestone Sep 23, 2024
@stgraber stgraber self-assigned this Sep 25, 2024
@hallyn hallyn closed this as completed in c0643ad Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed to be a bug Easy Good for new contributors
Development

No branches or pull requests

2 participants