Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxd-to-incus version mismatch #133

Closed
adamcstephens opened this issue Oct 7, 2023 · 2 comments
Closed

lxd-to-incus version mismatch #133

adamcstephens opened this issue Oct 7, 2023 · 2 comments
Assignees

Comments

@adamcstephens
Copy link
Contributor

adamcstephens commented Oct 7, 2023

Issue description

lxd-to-incus in tag incus-0.1 reports version 5.16. This is because lxd-to-incus is a completely separate go package and its parsing of the incus version is locked to what go.sum has.

Steps to reproduce

  1. Clone repo
  2. cd cmd/lxd-to-incus
  3. go build ./.
  4. ./lxd-to-incus --version
    5.16

Other

I'm attempting to finalize packaging incus for nixpkgs. Am I correct to assume that this should be 0.1 to match the incus version? Would it be better to maybe version it on its own? Since it's using go packages for all the incus dependencies, does it benefit from being in this repo?

@stgraber
Copy link
Member

stgraber commented Oct 7, 2023

It needs to stay in the repo so it can access the infernal packages but indeed will need a bit of tweaking to get the correct version as there's otherwise a bit of a chicken and egg problem.

The reason for the separate gomod is that we don't want the migration tool to cause the main gomod to include all of the LXD packages.

@stgraber stgraber added the bug label Oct 7, 2023
@stgraber stgraber self-assigned this Oct 7, 2023
@brauner brauner closed this as completed in ae360e8 Oct 7, 2023
@adamcstephens
Copy link
Contributor Author

adamcstephens commented Oct 7, 2023

Thank you!

─❯ ./result/bin/lxd-to-incus --version
0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants