Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hotplug/hotremove of paths to VMs #179

Closed
stgraber opened this issue Oct 19, 2023 · 2 comments
Closed

Add support for hotplug/hotremove of paths to VMs #179

stgraber opened this issue Oct 19, 2023 · 2 comments
Labels
Feature New feature, not a bug
Milestone

Comments

@stgraber
Copy link
Member

Suggested by @brauner

Currently we support adding/removing full disks (block) but not the 9p/virtiofs volumes.

@stgraber stgraber added Feature New feature, not a bug Easy Good for new contributors labels Oct 19, 2023
@stgraber stgraber added this to the incus-0.3 milestone Nov 1, 2023
@stgraber stgraber removed the Easy Good for new contributors label Nov 24, 2023
@stgraber
Copy link
Member Author

Looking around in QMP, there's no way for us to do this with 9p right now as there's no way to add an fsdev to a running daemon. It may be possible for virtiofs though as for that we just need chardev and device, both of which are supported in QMP, will need to do some extra tests for that.

This means that at least initially, we'll have to prevent path hotplug if migration.stateful is set to true or if the system is otherwise not supporting virtiofs.

@stgraber
Copy link
Member Author

Done some initial work on this, getting virtiofsd to get spawned and stopped on hotplug/hot-remove is easy enough, adding some restrictions to not needlessly spawn 9p and to check for migration.stateful was pretty simple too.

Now I'm at the stage where I need to fill in the QMP bits and hope that this part works properly too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature, not a bug
Development

No branches or pull requests

1 participant