Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of ISO volume size in restricted projects #284

Closed
stgraber opened this issue Dec 8, 2023 · 0 comments
Closed

Fix handling of ISO volume size in restricted projects #284

stgraber opened this issue Dec 8, 2023 · 0 comments
Assignees
Labels
Bug Confirmed to be a bug Easy Good for new contributors

Comments

@stgraber
Copy link
Member

stgraber commented Dec 8, 2023

When importing an ISO volume into a restricted project, we're currently getting:

stgraber@dakara:~/Downloads$ incus storage volume import --type=iso n-infra:remote win11.iso windows-11
Error: Failed creating custom volume from ISO: Failed checking volume creation allowed: Failed checking if volume creation allowed: Failed getting usage of project entities: Custom volume "windows-11" in project "dev-blue-team" has no "size" config set

Without digging into the code, I suspect that this is simply a small omission in the logic that receives the ISO and writes it into a storage volume. The size of the ISO volume is known precisely ahead of time as unlike other volume types, it's not decompressed or converted in any way on reception, it's just written byte for byte into a block volume.

@stgraber stgraber added Bug Confirmed to be a bug Easy Good for new contributors labels Dec 8, 2023
@stgraber stgraber self-assigned this Dec 8, 2023
@stgraber stgraber closed this as completed Dec 8, 2023
@stgraber stgraber reopened this Dec 8, 2023
@brauner brauner closed this as completed in 4feeb19 Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed to be a bug Easy Good for new contributors
Development

No branches or pull requests

1 participant