Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable OVN gateway chassis when evacuated #340

Closed
stgraber opened this issue Dec 28, 2023 · 4 comments · Fixed by #747
Closed

Disable OVN gateway chassis when evacuated #340

stgraber opened this issue Dec 28, 2023 · 4 comments · Fixed by #747
Assignees
Labels
Easy Good for new contributors
Milestone

Comments

@stgraber
Copy link
Member

As a machine that's evacuated is likely to be going down shortly thereafter, it would make sense for the evacuated state to be tied to either a disabled OVN gateway chassis state or at least a much lower chassis priority.

@stgraber stgraber added Feature Easy Good for new contributors labels Dec 28, 2023
@stgraber stgraber added this to the incus-0.7 milestone Feb 24, 2024
@stgraber stgraber modified the milestones: incus-0.7, incus-6.0 Mar 21, 2024
@Abhiram824
Copy link
Contributor

Could we be assigned to this as well please?

@stgraber stgraber modified the milestones: incus-6.0, soon Mar 29, 2024
@stgraber
Copy link
Member Author

For this one, you're going to want to look at cmd/incusd/api_cluster.go for the evacuation logic.

The easiest way to have the chassis disabled is going to be by stopping all networks while evacuated. So loading all local networks and calling Stop() on them should do that fine.

You'll also need to add a check to cmd/incusd/daemon.go so that on system startup the networks don't get started when the machine is evacuated (look for networkStartup).

Then you'll need logic in the evacuation restore logic to start the networks back up once the system is fully restored.

@Abhiram824
Copy link
Contributor

Hello! We made some progress and created a draft PR. Does our initial approach look correct?
#747

@dhruvvnistala
Copy link
Contributor

dhruvvnistala commented Apr 14, 2024

Hi, commenting on this post as per our discussion on #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy Good for new contributors
Development

Successfully merging a pull request may close this issue.

3 participants