Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

${{ steps.lychee.outputs.exit_code }} is not set correctly #244

Closed
sebastiaanspeck opened this issue Sep 25, 2024 · 1 comment · Fixed by #245
Closed

${{ steps.lychee.outputs.exit_code }} is not set correctly #244

sebastiaanspeck opened this issue Sep 25, 2024 · 1 comment · Fixed by #245

Comments

@sebastiaanspeck
Copy link
Contributor

sebastiaanspeck commented Sep 25, 2024

According to

lychee-action/action.yml

Lines 40 to 43 in 5047c2a

outputs:
exit_code:
description: "The exit code returned from Lychee"
value: ${{ steps.lychee.outputs.exit_code }}
${{ steps.lychee.outputs.exit_code }} should be set, but instead the exit_code is solely saved to an env lychee_exit_code.

IMO the quickest fix is to change it to:

echo "lychee_exit_code=$exit_code" >> $GITHUB_ENV
echo "exit_code=$exit_code" >> $GITHUB_OUTPUT
@mre
Copy link
Member

mre commented Sep 26, 2024

Oh, that's bad. Would you mind opening a pull request to apply your suggested fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants