Upgrade to ember 3.20 LTS #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patocallaghan
force-pushed
the
patoc/ember-cli-upgrade
branch
6 times, most recently
from
24995d0 to
557845c
Compare
patocallaghan
force-pushed
the
patoc/ember-cli-upgrade
branch
from
557845c to
3e889ee
Compare
patocallaghan
force-pushed
the
patoc/ember-cli-upgrade
branch
from
3e889ee to
6eba4bb
Compare
|
Hey @patocallaghan I'm good to merge this but I still have a fair amount of CI repositories at work I gotta find a way to convert to two-factor authentication before I can rejoin this org. Another option will be if it gets moved to ember-adopted-addons then someone else can merge it. |
|
@jakesjews is the blocker here that you need 2FA on your github account to get access to this repo now, but you don't have 2FA enabled on your work repos? |
|
we have some small internal stuff using my account and we're pretty understaffed at the moment so its hard to justify to management to take time out to check them all |
|
@jakesjews since I've commit access now and you were happy with this PR I'm going to merge |
|
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 5.0 beta is introducing breaking changes we may as well upgrade to the latest 3.20 LTS and drop Node 8.
@ember-data/..import syntax/cc @jakesjews