Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FromCtx and IntoCtx for pe structs #277

Open
Ben-Lichtman opened this issue Jul 1, 2021 · 1 comment
Open

Support FromCtx and IntoCtx for pe structs #277

Ben-Lichtman opened this issue Jul 1, 2021 · 1 comment

Comments

@Ben-Lichtman
Copy link

Ben-Lichtman commented Jul 1, 2021

the layout of PE structs is pretty well documented, so it should be possible to turn PEs to and from bytes.

If this is not completely possible, it should at least be mostly possible - however many of the headers don't implement the correct traits.

@m4b
Copy link
Owner

m4b commented Jul 4, 2021

So I thought the PE structs implemented FromCtx (reading) ? However for I don't think IntoCtx has been implemented yet (writing)

That would be pretty awesome :) I think the only reason it isn't done is simply no one had the time to write the corresponding IntoCtx trait impls (e.g., like was done for mach + elf); if you'd like to send a PR, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants